Page MenuHomePhabricator

Fix some minor Calendar issues, including a paging issue on imports
ClosedPublic

Authored by epriestley on Nov 1 2016, 8:59 PM.

Details

Summary

Fixes T11808. I couldn't reproduce the issue there locally so I'm just cheating a little bit until a better reproduction case shows up.

We don't need to do a full load here anyway, and testing for any row is more efficient.

Test Plan

Poked around imports without issues, but couldn't reproduce this problem locally.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 40430.Nov 1 2016, 8:59 PM
epriestley retitled this revision from to Fix some minor Calendar issues, including a paging issue on imports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 40431.Nov 1 2016, 9:01 PM
  • Also fix an issue importing events with no attendees that I caught in the production logs.
epriestley updated this revision to Diff 40432.Nov 1 2016, 9:17 PM
  • Also fix an issue which could cause reminder notifications for events which started up to 5 minutes ago.
chad accepted this revision.Nov 1 2016, 9:39 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 1 2016, 9:39 PM
This revision was automatically updated to reflect the committed changes.