Page MenuHomePhabricator
Differential D16749

Support RRULE "COUNT" for recurring events
ClosedPublic
Actions

Authored by epriestley on Oct 25 2016, 5:32 PM.
Tags
None
Referenced Files
F13107177: D16749.id.diff
Sat, Apr 27, 10:00 PM
F13105565: D16749.diff
Sat, Apr 27, 4:12 PM
Unknown Object (File)
Thu, Apr 25, 2:58 AM
Unknown Object (File)
Fri, Apr 19, 5:31 PM
Unknown Object (File)
Tue, Apr 16, 12:20 AM
Unknown Object (File)
Fri, Apr 12, 3:51 PM
Unknown Object (File)
Thu, Apr 11, 12:49 AM
Unknown Object (File)
Wed, Apr 3, 5:03 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rP48666839feb5: Support RRULE "COUNT" for recurring events
Summary

Ref T10747. RRULE events can repeat "UNTIL" a certain time, or a certain "COUNT" of times.

In the UI, we only support "UNTIL". Also support "COUNT".

Test Plan

Imported an event which repeats every other day, 5 times. Got 5 instances.

Diff Detail

Repository
rP Phabricator
Branch
cimport2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14229
Build 18500: Run Core Tests
Build 18499: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40335.Oct 25 2016, 5:32 PM
epriestley retitled this revision from to Support RRULE "COUNT" for recurring events.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 25 2016, 5:34 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 25 2016, 5:34 PM
chad requested changes to this revision.Oct 25 2016, 5:37 PM
chad edited edge metadata.
This revision now requires changes to proceed.Oct 25 2016, 5:37 PM
chad accepted this revision.Oct 25 2016, 5:37 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 25 2016, 5:37 PM
epriestley added a comment.Oct 25 2016, 5:38 PM

iiam

Closed by commit rP48666839feb5: Support RRULE "COUNT" for recurring events (authored by epriestley, committed by epriestley). · Explain WhyOct 25 2016, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
import/
3 lines
query/
5 lines
storage/
23 lines

Diff 40335

View Options

src/applications/calendar/import/PhabricatorCalendarImportEngine.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
Phabricator · Built by Phacility