Differential D16748

Fix import casts for RRULE "INTERVAL" and "COUNT" properties
ClosedPublic
Actions

Authored by epriestley on Oct 25 2016, 5:18 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHU6d6308803540: Fix import casts for RRULE "INTERVAL" and "COUNT" properties

Summary

Ref T10747. When present, these should both be integers.

Test Plan

Imported an event repeating 5 times, every other day.

Diff Detail

Repository

rPHU libphutil

Branch

cimport2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14228
Build 18498: Run Core Tests
Build 18497: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40334.Oct 25 2016, 5:18 PM

epriestley retitled this revision from to Fix import casts for RRULE "INTERVAL" and "COUNT" properties.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 25 2016, 5:33 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 25 2016, 5:33 PM

Closed by commit rPHU6d6308803540: Fix import casts for RRULE "INTERVAL" and "COUNT" properties (authored by epriestley, committed by epriestley). · Explain WhyOct 25 2016, 5:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

19 lines

Diff 40334

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Fix import casts for RRULE "INTERVAL" and "COUNT" propertiesClosedPublicActions