Make "aliases" show up in "arc get-config" help
ClosedPublic
Actions

Authored by epriestley on Oct 21 2016, 9:44 PM.

Details

Reviewers

chad

Maniphest Tasks

T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config"

Commits

rARCfad85844314b: Make "aliases" show up in "arc get-config" help

Summary

Fixes T11758. This was one some spooky magic but is more-or-less a normal config setting now.

Test Plan

Ran arc get-config, saw help about "aliases".
Ran arc set-config aliases, saw guidance about using arc alias.

Diff Detail

Repository

rARC Arcanist

Branch

asetting1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14220
Build 18486: Run Core Tests
Build 18485: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40328.Oct 21 2016, 9:44 PM

epriestley retitled this revision from to Make "aliases" show up in "arc get-config" help.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11758: "aliases" is valid configuration in Arcanist, but not recognized by "arc get-config".

chad accepted this revision.Oct 21 2016, 9:50 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 21 2016, 9:50 PM

Closed by commit rARCfad85844314b: Make "aliases" show up in "arc get-config" help (authored by epriestley, committed by epriestley). · Explain WhyOct 21 2016, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

configuration/

ArcanistSettings.php

12 lines

Diff 40328

View Options

src/configuration/ArcanistSettings.php

Make "aliases" show up in "arc get-config" helpClosedPublicActions