Page MenuHomePhabricator

Optimize filtering private threads when querying Conpherence
ClosedPublic

Authored by epriestley on Oct 20 2016, 8:32 PM.
Tags
None
Referenced Files
F14058463: D16740.diff
Sun, Nov 17, 12:23 PM
F14009133: D16740.diff
Wed, Oct 30, 10:35 AM
F13983757: D16740.id40314.diff
Sun, Oct 20, 8:29 AM
F13960951: D16740.id40310.diff
Oct 15 2024, 2:18 AM
F13960603: D16740.id.diff
Oct 15 2024, 12:17 AM
Unknown Object (File)
Oct 9 2024, 6:01 AM
Unknown Object (File)
Oct 2 2024, 4:23 PM
Unknown Object (File)
Sep 1 2024, 5:32 AM
Subscribers
None

Details

Summary

Because most threads are private, this query can overheat the policy filter (today, probably only on this install).

Improve the common case by skipping "Visible To: Room Participants" threads if the viewer isn't a participant. This means they don't hit the application and don't count toward overheating the filter.

Test Plan

Viewed Conpherence threads.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Optimize filtering private threads when querying Conpherence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 8:36 PM
This revision was automatically updated to reflect the committed changes.