Page MenuHomePhabricator

Optimize filtering private threads when querying Conpherence
ClosedPublic

Authored by epriestley on Oct 20 2016, 8:32 PM.
Tags
None
Referenced Files
F18031569: D16740.diff
Sun, Aug 3, 12:03 AM
Unknown Object (File)
Jun 17 2025, 8:58 AM
Unknown Object (File)
Jun 16 2025, 12:09 PM
Unknown Object (File)
May 29 2025, 8:42 AM
Unknown Object (File)
May 10 2025, 6:49 AM
Unknown Object (File)
May 5 2025, 9:57 AM
Unknown Object (File)
Apr 26 2025, 1:13 AM
Unknown Object (File)
Apr 11 2025, 7:54 PM
Subscribers
None

Details

Summary

Because most threads are private, this query can overheat the policy filter (today, probably only on this install).

Improve the common case by skipping "Visible To: Room Participants" threads if the viewer isn't a participant. This means they don't hit the application and don't count toward overheating the filter.

Test Plan

Viewed Conpherence threads.

Diff Detail

Repository
rP Phabricator
Branch
tquery1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14202
Build 18460: Run Core Tests
Build 18459: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Optimize filtering private threads when querying Conpherence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 20 2016, 8:36 PM
This revision was automatically updated to reflect the committed changes.