HomePhabricator

Hold a lock while collecting garbage

Authored by epriestley on Oct 20 2016, 6:36 PM.

Description

Hold a lock while collecting garbage

Summary:
Fixes T11771. Adds a lock around each GC process so we don't try to, e.g., delete old files on two machines at once just because they're both running trigger daemons.

The other aspects of this daemon (actual triggers; nuance importers) already have separate locks.

Test Plan: Ran bin/phd debug trigger --trace, saw daemon acquire locks and collect garbage.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11771

Differential Revision: https://secure.phabricator.com/D16739

Details

Committed
epriestleyOct 20 2016, 8:40 PM
Pushed
epriestleyOct 20 2016, 8:40 PM
Reviewer
chad
Differential Revision
D16739: Hold a lock while collecting garbage
Parents
rP272046ae7701: Write a basic SSH pull log for Git
Branches
Unknown
Tags
Unknown
Tasks
T11771: Protect GC operations with a lock
Build Status
Buildable 14205
Build 18463: Run Core Tests