Differential D16728

When generating Calendar event stubs, inherit import properties
ClosedPublic
Actions

Authored by epriestley on Oct 19 2016, 4:20 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPc3de8f8305a9: When generating Calendar event stubs, inherit import properties

Summary

Ref T10747. Previously, importing a recurring event failed to mark the instnaces of the event as imported.

Now, we copy the source/UID/importer over.

Test Plan

Imported a recurring event, viewed event series, saw all of them marked imported.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40281.Oct 19 2016, 4:20 PM

epriestley retitled this revision from to When generating Calendar event stubs, inherit import properties.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 19 2016, 4:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 19 2016, 4:25 PM

Closed by commit rPc3de8f8305a9: When generating Calendar event stubs, inherit import properties (authored by epriestley, committed by epriestley). · Explain WhyOct 19 2016, 4:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

16 lines

Diff 40286

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

When generating Calendar event stubs, inherit import propertiesClosedPublicActions