Page MenuHomePhabricator

When import fails because we can't parse an ICS file, show it nicely
ClosedPublic

Authored by epriestley on Oct 18 2016, 8:54 PM.
Tags
None
Referenced Files
F13157385: D16721.diff
Sun, May 5, 11:25 AM
Unknown Object (File)
Fri, May 3, 2:16 AM
Unknown Object (File)
Mon, Apr 29, 1:39 PM
Unknown Object (File)
Wed, Apr 24, 9:52 PM
Unknown Object (File)
Sun, Apr 21, 3:44 PM
Unknown Object (File)
Fri, Apr 19, 5:29 PM
Unknown Object (File)
Wed, Apr 17, 2:37 PM
Unknown Object (File)
Thu, Apr 11, 6:59 AM
Subscribers
None

Details

Summary

Ref T10747. When we hit an ICS parser error, render it into a log instead of fataling.

(This will be more important in the future with subscription-based URL ICS import.)

Test Plan

Screen Shot 2016-10-18 at 1.49.43 PM.png (904×1 px, 133 KB)

Diff Detail

Repository
rP Phabricator
Branch
cimport12
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/calendar/import/PhabricatorCalendarICSImportEngine.php:70XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14160
Build 18393: Run Core Tests
Build 18392: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When import fails because we can't parse an ICS file, show it nicely.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.