Fixes the send on enter flash, only uses the Threads loading animation on changing threads, not sending a message.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T3165: Provide Search in Conpherence
- Commits
- rP636eaf231ec4: Only show loading animation on thread change in Conpherence
Change threads, post a message.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- nukenukenuke (branched from master)
- Lint
Lint Warnings Severity Location Code Message Warning webroot/rsrc/js/application/conpherence/behavior-menu.js:214 W003 JSHintW003 - Unit
No Test Coverage - Build Status
Buildable 14114 Build 18322: Run Core Tests Build 18321: arc lint + arc unit
Event Timeline
Comment Actions
in theory you should do like this:
// this first
function thing() {
}
// this later
thing();You can also trick the linter like this:
thing();
var thing = function() {
// sneaky!
};In practice this does not matter too much but sometimes the code is a little cleaner?