Page MenuHomePhabricator

Only show loading animation on thread change in Conpherence
ClosedPublic

Authored by chad on Oct 14 2016, 2:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:31 PM
Unknown Object (File)
Fri, Apr 12, 9:33 AM
Unknown Object (File)
Thu, Apr 11, 6:57 AM
Unknown Object (File)
Sat, Apr 6, 6:54 AM
Unknown Object (File)
Fri, Apr 5, 2:54 PM
Unknown Object (File)
Wed, Apr 3, 12:27 AM
Unknown Object (File)
Feb 2 2024, 9:30 AM
Unknown Object (File)
Jan 21 2024, 4:49 AM
Subscribers

Details

Summary

Fixes the send on enter flash, only uses the Threads loading animation on changing threads, not sending a message.

Test Plan

Change threads, post a message.

Diff Detail

Repository
rP Phabricator
Branch
nukenukenuke (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/application/conpherence/behavior-menu.js:214W003JSHintW003
Unit
No Test Coverage
Build Status
Buildable 14114
Build 18322: Run Core Tests
Build 18321: arc lint + arc unit

Event Timeline

chad retitled this revision from to Only show loading animation on thread change in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

in theory you should do like this:

// this first
function thing() {
}

// this later
thing();

You can also trick the linter like this:

thing();

var thing = function() {
  // sneaky!
};

In practice this does not matter too much but sometimes the code is a little cleaner?

This revision is now accepted and ready to land.Oct 14 2016, 2:53 AM
This revision was automatically updated to reflect the committed changes.