Page MenuHomePhabricator
Differential D16703

When viewing a Calendar import, show all the events it imported
ClosedPublic
Actions

Authored by epriestley on Oct 13 2016, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 5:28 PM
Unknown Object (File)
Wed, Apr 17, 1:27 PM
Unknown Object (File)
Sat, Apr 13, 3:59 AM
Unknown Object (File)
Sat, Apr 13, 3:59 AM
Unknown Object (File)
Sat, Apr 13, 3:59 AM
Unknown Object (File)
Sat, Apr 13, 3:54 AM
Unknown Object (File)
Sat, Apr 13, 2:38 AM
Unknown Object (File)
Fri, Apr 12, 11:31 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPc2411e3dcc9c: When viewing a Calendar import, show all the events it imported
Summary

Ref T10747. Show which events a source imported, and link to the full list as a query result.

Test Plan

Screen Shot 2016-10-13 at 8.51.17 AM.png (1×1 px, 148 KB)

Diff Detail

Repository
rP Phabricator
Branch
cimport5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 14100
Build 18300: Run Core Tests
Build 18299: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40206.Oct 13 2016, 3:52 PM
epriestley retitled this revision from to When viewing a Calendar import, show all the events it imported.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Oct 13 2016, 4:03 PM
chad edited edge metadata.
chad added inline comments.
src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
148

could probably bump this to 25.

This revision is now accepted and ready to land.Oct 13 2016, 4:03 PM
epriestley updated this revision to Diff 40207.Oct 13 2016, 4:04 PM
epriestley edited edge metadata.
  • Use 25.
Closed by commit rPc2411e3dcc9c: When viewing a Calendar import, show all the events it imported (authored by epriestley, committed by epriestley). · Explain WhyOct 13 2016, 4:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
45 lines
query/
8 lines

Diff 40207

View Options

src/applications/calendar/controller/PhabricatorCalendarImportViewController.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
Phabricator · Built by Phacility