Paths

Table of Contentst

Force a couple of Conduit results to the proper types in Calendar
ClosedPublic
Actions

Authored by epriestley on Oct 11 2016, 7:34 PM.

Tags

None

Referenced Files

	F15460371: D16690.diff
	Mon, Mar 31, 10:23 PM

	F15457576: D16690.id40182.diff
	Sun, Mar 30, 5:17 PM

	F15457575: D16690.id40180.diff
	Sun, Mar 30, 5:17 PM

	F15457574: D16690.id.diff
	Sun, Mar 30, 5:17 PM

	F15446048: D16690.id40182.diff
	Thu, Mar 27, 4:55 PM

	F15446047: D16690.id40180.diff
	Thu, Mar 27, 4:55 PM

	F15446046: D16690.id.diff
	Thu, Mar 27, 4:55 PM

	F15442646: D16690.diff
	Wed, Mar 26, 11:53 PM

View All Files

Subscribers

None

Tokens

"Love" token, awarded by 20after4.

Details

Reviewers

chad

Maniphest Tasks

T11706: Retrieve event date from Calendar "calendar.event.search" method API

Commits

rP13b4b37d30d2: Force a couple of Conduit results to the proper types in Calendar

Summary

Ref T11706. Add some casts so we don't return "0" for false.

Also I forgot to document one of the things.

Test Plan

Called calendar.event.search.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40180.Oct 11 2016, 7:34 PM

epriestley retitled this revision from to Force a couple of Conduit results to the proper types in Calendar.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11706: Retrieve event date from Calendar "calendar.event.search" method API.

chad accepted this revision.Oct 11 2016, 7:35 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 11 2016, 7:35 PM

Closed by commit rP13b4b37d30d2: Force a couple of Conduit results to the proper types in Calendar (authored by epriestley, committed by epriestley). · Explain WhyOct 11 2016, 8:00 PM

This revision was automatically updated to reflect the committed changes.

20after4 awarded a token.Oct 12 2016, 8:10 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

8 lines

Diff 40182

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Force a couple of Conduit results to the proper types in CalendarClosedPublicActions