Page MenuHomePhabricator

Export recurring events and build ICS files for configured exports
ClosedPublic

Authored by epriestley on Oct 6 2016, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 27, 6:06 PM
Unknown Object (File)
Sun, Jan 26, 9:06 AM
Unknown Object (File)
Sun, Jan 26, 9:06 AM
Unknown Object (File)
Sun, Jan 26, 8:30 AM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Sat, Jan 25, 2:11 PM
Unknown Object (File)
Thu, Jan 23, 8:36 PM
Subscribers
None

Details

Summary

Ref T10747. This:

  • Exports recurring events properly, with RRULE + RECURRENCE-ID.
  • When exporting a part of an event series, export the whole series to ICS so it is represented faithfully.
  • Make the subscribable URL for "Export" objects work.
Test Plan
  • Downloaded the ".ics" for a normal event, imported it into Calendar.app and Google Calendar.
  • Downloaded the ".ics" for a recurring event, imported it into Calendar.app and Google Calendar.
  • Defined an ".ics" Export of my events, subscribed to them in Calendar.app.
    • Edited an event in Phabricator.
    • Hit +R in Calendar.app, saw changes. (MAGIC!)
    • This export included recurring events, which appeared the same way in Calendar.app and Phabricator.
  • Can't import into Google Calendar from my local install easily since Google's servers can't hit my laptop, but I'll test once we deploy.

Diff Detail

Repository
rP Phabricator
Branch
cal1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/calendar/storage/PhabricatorCalendarEvent.php:694XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14047
Build 18221: Run Core Tests
Build 18220: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Export recurring events and build ICS files for configured exports.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.