Differential D16668

Drive calendar event queries through the RRULE engine
ClosedPublic
Actions

Authored by epriestley on Oct 5 2016, 5:07 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rP20f7de91ceb5: Drive calendar event queries through the RRULE engine

Summary

Ref T10747. This drives event queries through RRULE, too.

Test Plan

Created recurring events, saw them appear correctly on the calendar.

Diff Detail

Repository

rP Phabricator

Branch

cal9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 14014
Build 18172: Run Core Tests
Build 18171: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40124.Oct 5 2016, 5:07 PM

epriestley retitled this revision from to Drive calendar event queries through the RRULE engine.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Oct 5 2016, 5:32 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 5 2016, 5:32 PM

Closed by commit rP20f7de91ceb5: Drive calendar event queries through the RRULE engine (authored by epriestley, committed by epriestley). · Explain WhyOct 6 2016, 10:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventQuery.php

126 lines

storage/

PhabricatorCalendarEvent.php

35 lines

Diff 40124

View Options

src/applications/calendar/query/PhabricatorCalendarEventQuery.php