Differential D16631

Add SECONDLY tests to RRULE code
ClosedPublic
Actions

Authored by epriestley on Sep 29 2016, 7:12 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

rPHUb077cfaf1b07: Add SECONDLY tests to RRULE code

Summary

Ref T10747. These pretty much worked. BYSETPOS does not make sense with SECONDLY, as far as I can tell.

Test Plan

Unit tests pass.

Diff Detail

Repository

rPHU libphutil

Branch

cal6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13927
Build 18035: Run Core Tests
Build 18034: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 40038.Sep 29 2016, 7:12 PM

epriestley retitled this revision from to Add SECONDLY tests to RRULE code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10747: Import and export ICS from Calendar.

chad accepted this revision.Sep 29 2016, 8:25 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2016, 8:25 PM

Closed by commit rPHUb077cfaf1b07: Add SECONDLY tests to RRULE code (authored by epriestley, committed by epriestley). · Explain WhySep 29 2016, 11:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

calendar/

data/

PhutilCalendarRecurrenceRule.php

3 lines

__tests__/

PhutilCalendarRecurrenceRuleTestCase.php

49 lines

Diff 40038

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

View Options

src/parser/calendar/data/tests/PhutilCalendarRecurrenceRuleTestCase.php

Add SECONDLY tests to RRULE codeClosedPublicActions