Page MenuHomePhabricator

Convert Durable Column to popup chat in footer
ClosedPublic

Authored by chad on Sep 29 2016, 5:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 27, 11:55 AM
Unknown Object (File)
Fri, Jan 27, 6:31 AM
Unknown Object (File)
Sat, Jan 14, 11:41 PM
Unknown Object (File)
Sat, Jan 14, 11:41 PM
Unknown Object (File)
Fri, Jan 13, 11:23 PM
Unknown Object (File)
Wed, Jan 11, 5:58 PM
Unknown Object (File)
Wed, Jan 11, 5:58 PM
Unknown Object (File)
Wed, Jan 11, 5:58 PM
Subscribers

Details

Summary

This feels pretty reasonable with little effort, and I think I'd use it more than the full column.

Test Plan

Chat a lot on various pages.... still some quicksand quirks around various pages.

pasted_file (2×2 px, 405 KB)

Diff Detail

Repository
rP Phabricator
Branch
tiny-chit-chat (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13921
Build 18025: Run Core Tests
Build 18024: arc lint + arc unit

Event Timeline

chad retitled this revision from to Convert Durable Column to popup chat in footer.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • remove durable margin js, hide chat on devices
  • fix language, remove unused JS var
epriestley edited edge metadata.

I find the Facebook version of this frustrating because I feel like it's never big enough to let me read all the text I want to see so I have to scroll around, but I don't think I'm the target audience for the column anyway given how heavily I use multiple tabs/windows.

This revision is now accepted and ready to land.Sep 29 2016, 4:13 PM

I've got some more tricks coming I think for space on messages. @scp gave me some ideas for free.

This revision was automatically updated to reflect the committed changes.

The first one's always free...