Differential D16627

Convert Durable Column to popup chat in footer
ClosedPublic
Actions

Authored by chad on Sep 29 2016, 5:14 AM.

Details

Reviewers

epriestley

Commits

rP95d174956639: Convert Durable Column to popup chat in footer

Summary

This feels pretty reasonable with little effort, and I think I'd use it more than the full column.

Test Plan

Chat a lot on various pages.... still some quicksand quirks around various pages.

Diff Detail

Repository

rP Phabricator

Branch

tiny-chit-chat (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13919
Build 18021: Run Core Tests
Build 18020: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 40030.Sep 29 2016, 5:14 AM

chad retitled this revision from to Convert Durable Column to popup chat in footer.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 29 2016, 5:14 AM

remove durable margin js, hide chat on devices

chad edited the test plan for this revision. (Show Details)Sep 29 2016, 5:23 AM

fix language, remove unused JS var

I find the Facebook version of this frustrating because I feel like it's never big enough to let me read all the text I want to see so I have to scroll around, but I don't think I'm the target audience for the column anyway given how heavily I use multiple tabs/windows.

This revision is now accepted and ready to land.Sep 29 2016, 4:13 PM