Page MenuHomePhabricator
Differential D16608

Fix a RRULE issue with BYDAY and similar constraints in noninitial months
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 11:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 2:29 AM
Unknown Object (File)
Tue, Feb 4, 8:17 AM
Unknown Object (File)
Tue, Feb 4, 8:17 AM
Unknown Object (File)
Tue, Feb 4, 8:17 AM
Unknown Object (File)
Tue, Feb 4, 7:45 AM
Unknown Object (File)
Fri, Jan 31, 2:39 PM
Unknown Object (File)
Wed, Jan 29, 5:49 PM
Unknown Object (File)
Sat, Jan 25, 2:07 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10747: Import and export ICS from Calendar
Commits
rPHUa1254d047a55: Fix a RRULE issue with BYDAY and similar constraints in noninitial months
Summary

Ref T10747. This latest test failed beacuse the start date (the 2nd) carried over to the first month we could actually examine.

Test Plan

Unit test now passes.

Diff Detail

Repository
rPHU libphutil
Branch
cal6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13870
Build 17948: Run Core Tests
Build 17947: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39981.Sep 27 2016, 11:20 PM
epriestley retitled this revision from to Fix a RRULE issue with BYDAY and similar constraints in noninital months.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10747: Import and export ICS from Calendar.
chad accepted this revision.Sep 27 2016, 11:25 PM
chad retitled this revision from Fix a RRULE issue with BYDAY and similar constraints in noninital months to Fix a RRULE issue with BYDAY and similar constraints in noninitial months.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 27 2016, 11:25 PM
Closed by commit rPHUa1254d047a55: Fix a RRULE issue with BYDAY and similar constraints in noninitial months (authored by epriestley, committed by epriestley). · Explain WhySep 28 2016, 12:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
calendar/
data/
31 lines
__tests__/
19 lines

Diff 39981

View Options

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php

Loading...
View Options

src/parser/calendar/data/__tests__/PhutilCalendarRecurrenceRuleTestCase.php

Loading...
Phabricator · Built by Phacility