Validate various RRULE components and simplify logic slightly
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 6:41 PM.

Details

Reviewers

chad

Maniphest Tasks

T10747: Import and export ICS from Calendar

Commits

Summary

Validate that all the values are in the proper ranges (this does not yet implement some rules which take more than one value into account, e.g. BYDAY may not be in the form "+1TU" unless FREQUENCY is MONTHLY or YEARLY).
Use constants instead of magic strings.
Do array_fuse() mangling earlier.
Fix a couple of the TODOs around weekday stuff.
Implement (probably) more of the BY* rules.
Other minor simplification/cleanup.

Test Plan

Unit tests still pass.

Repository

rPHU libphutil

Branch

cal2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/parser/calendar/data/PhutilCalendarRecurrenceRule.php:596	XHP16	TODO Comment
Advice	src/parser/calendar/data/PhutilCalendarRecurrenceRule.php:720	XHP16	TODO Comment

Unit

Tests Passed

Build Status

epriestley retitled this revision from to Validate various RRULE components and simplify logic slightly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

src/parser/calendar/data/PhutilCalendarRecurrenceRule.php
560	The "SCALE" stuff is mostly to clean up these huge `X \|\| Y \|\| Z` conditions -- this is the worst one.
853	Just changed this to make it a little more human-readable.