Page MenuHomePhabricator
Differential D16601

When summing points on a workboard, display sum with same precision as most-precise value
ClosedPublic
Actions

Authored by epriestley on Sep 27 2016, 4:31 PM.
Tags
None
Referenced Files
F14355878: D16601.diff
Thu, Dec 19, 6:48 PM
Unknown Object (File)
Thu, Dec 12, 7:21 PM
Unknown Object (File)
Thu, Dec 12, 7:58 AM
Unknown Object (File)
Mon, Dec 9, 11:43 PM
Unknown Object (File)
Sat, Dec 7, 8:11 PM
Unknown Object (File)
Sat, Dec 7, 7:07 AM
Unknown Object (File)
Sun, Dec 1, 5:11 PM
Unknown Object (File)
Tue, Nov 26, 1:27 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T11703: Floating point issue on points on workboards
Commits
rPf2bb9bc06143: When summing points on a workboard, display sum with same precision as most…
Summary

Fixes T11703. This mostly avoids rounding errors.

If point values include "0.001", we also get three digits of precision: 1.000.

Maybe useful if your point field is called "bitcoins" or something.

Test Plan

Before:

Screen Shot 2016-09-27 at 9.21.16 AM.png (404×319 px, 19 KB)

After:

Screen Shot 2016-09-27 at 9.29.05 AM.png (497×968 px, 51 KB)

Diff Detail

Repository
rP Phabricator
Branch
fixed1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13853
Build 17920: Run Core Tests
Build 17919: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39964.Sep 27 2016, 4:31 PM
epriestley retitled this revision from to When summing points on a workboard, display sum with same precision as most-precise value.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T11703: Floating point issue on points on workboards.
epriestley mentioned this in T11703: Floating point issue on points on workboards.Sep 27 2016, 4:32 PM
chad accepted this revision.Sep 27 2016, 4:36 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 27 2016, 4:36 PM
Closed by commit rPf2bb9bc06143: When summing points on a workboard, display sum with same precision as most… (authored by epriestley, committed by epriestley). · Explain WhySep 27 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
webroot/
rsrc/
js/
application/
projects/
11 lines

Diff 39964

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/projects/WorkboardColumn.js

Loading...
Phabricator · Built by Phacility