Expose Drydock authorizations via Conduit
ClosedPublic
Actions

Authored by yelirekim on Sep 24 2016, 6:49 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T11694: Allow clients to generally reason about Drydock leases over the API

Commits

rPfa90f8bef413: Expose Drydock authorizations via Conduit

Summary

DrydockAuthorizationSearchEngine was being used solely to display authorizations for a specific blueprint from the web UI and consequently expected that callers set a specific blueprint before performing a query. Here we check to see if a blueprint has been set in cases where the engine could be operating from either Conduit or the web.

Ref T11694

Test Plan

called the API method from the console
approved an authorization
followed the "view all" link from a blueprint page

Diff Detail

Repository

rP Phabricator

Branch

authorization_search (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13832
Build 17881: Run Core Tests
Build 17880: arc lint + arc unit

Event Timeline

yelirekim updated this revision to Diff 39943.Sep 24 2016, 6:49 AM

yelirekim retitled this revision from to Expose Drydock authorizations via Conduit.

yelirekim updated this object.

yelirekim edited the test plan for this revision. (Show Details)

yelirekim added a task: T11694: Allow clients to generally reason about Drydock leases over the API.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 24 2016, 6:49 AM

Herald added a subscriber: epriestley. · View Herald Transcript

epriestley accepted this revision.Sep 26 2016, 1:49 PM

epriestley added a reviewer: epriestley.

epriestley added inline comments.

src/applications/drydock/query/DrydockAuthorizationSearchEngine.php
59	Unnecessary? What problem does it create if you omit this?
64	Maybe we should think about picking a better name for an authorization's "Object" now that it's becoming more user-facing, but "authorizee" or "grantee" seem kind of terrible, and a generic like "Target" isn't really less overloaded than "Object".