Page MenuHomePhabricator
Differential D16566

Manage Drydock leases from arcanist
Needs ReviewPublic
Actions

Authored by yelirekim on Sep 17 2016, 1:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 9:21 AM
Unknown Object (File)
Mon, Apr 1, 11:15 PM
Unknown Object (File)
Mon, Apr 1, 2:11 PM
Unknown Object (File)
Sat, Mar 30, 2:39 AM
Unknown Object (File)
Thu, Mar 28, 6:02 PM
Unknown Object (File)
Mar 16 2024, 3:29 AM
Unknown Object (File)
Mar 14 2024, 2:56 PM
Unknown Object (File)
Feb 3 2024, 11:58 AM
View All Files
Subscribers
chad
epriestley
Tokens
"Love" token, awarded by hach-que.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Depends on D16565. Glues together all of the methods therein so that arcanist can acquire and release leases.

Test Plan

leased a working copy using arc lease, released it using arc release

Diff Detail

Repository
rARC Arcanist
Branch
lease_workflow (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistLeaseWorkflow.php:206XHP48Array Separator
Unit
Tests Passed
Build Status
Buildable 13752
Build 17759: Run Core Tests
Build 17758: arc lint + arc unit

Event Timeline

yelirekim updated this revision to Diff 39875.Sep 17 2016, 1:57 AM
yelirekim retitled this revision from to Manage Drydock leases from arcanist.
yelirekim updated this object.
yelirekim edited the test plan for this revision. (Show Details)
yelirekim added a parent revision: D16565: Expose Drydock lease management from conduit.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 17 2016, 1:57 AM
Herald added a subscriber: epriestley. · View Herald Transcript
yelirekim updated this revision to Diff 39876.Sep 17 2016, 1:58 AM
yelirekim edited edge metadata.

fix lint problem

chad added a subscriber: chad.Sep 17 2016, 2:14 AM
chad added inline comments.
src/workflow/ArcanistReleaseWorkflow.php
93–95

do these need pht()?

hach-que awarded a token.Sep 18 2016, 3:33 AM
yelirekim added inline comments.Sep 19 2016, 5:22 PM
src/workflow/ArcanistReleaseWorkflow.php
93–95

I don't see why they wouldn't, but also I am really lazy today. I will do this tomorrow / or whenever I'm pretty sure you guys don't want me to actually just delete all of this code.

epriestley added a comment.Sep 21 2016, 4:50 PM

The shape of this looks generally reasonable to me, but I don't want to bring some of the endpoints it relies on upstream yet.

(For anyone finding their way here, D16565 has more discussion.)

yelirekim mentioned this in T11693: Make drydock command interfaces accessible via SSH workflows.Sep 24 2016, 4:12 AM
• liugev6 added a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 8:51 AM
epriestley removed a commit: rP88a966993be1: Ajax commenting on lightbox images.Nov 22 2016, 12:09 PM
• TweikerManager added a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:50 PM
epriestley removed a commit: rP2604c5af55f6: (stable) Promote 2017 Week 4.Jan 29 2017, 10:52 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
src/
4 lines--
workflow/
213 lines0%
Loading...
108 lines0%
Loading...

Diff 39875

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/workflow/ArcanistLeaseWorkflow.php

Loading...
View Options

src/workflow/ArcanistReleaseWorkflow.php

Loading...
Phabricator · Built by Phacility