Page MenuHomePhabricator

Manage Drydock leases from arcanist
Needs ReviewPublic

Authored by yelirekim on Sep 17 2016, 1:57 AM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Summary

Depends on D16565. Glues together all of the methods therein so that arcanist can acquire and release leases.

Test Plan

leased a working copy using arc lease, released it using arc release

Diff Detail

Repository
rARC Arcanist
Branch
lease_workflow (branched from master)
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/workflow/ArcanistLeaseWorkflow.php:206XHP48Array Separator
Unit
Tests Passed
Build Status
Buildable 13752
Build 17759: Run Core Tests
Build 17758: arc lint + arc unit

Event Timeline

yelirekim retitled this revision from to Manage Drydock leases from arcanist.
yelirekim updated this object.
yelirekim edited the test plan for this revision. (Show Details)
yelirekim edited edge metadata.

fix lint problem

chad added inline comments.
src/workflow/ArcanistReleaseWorkflow.php
93–95

do these need pht()?

src/workflow/ArcanistReleaseWorkflow.php
93–95

I don't see why they wouldn't, but also I am really lazy today. I will do this tomorrow / or whenever I'm pretty sure you guys don't want me to actually just delete all of this code.

The shape of this looks generally reasonable to me, but I don't want to bring some of the endpoints it relies on upstream yet.

(For anyone finding their way here, D16565 has more discussion.)