Just fatal for any setting of open_basedir
ClosedPublic
Actions

Authored by epriestley on Sep 12 2016, 9:45 PM.

Details

Reviewers

Maniphest Tasks

T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action

Commits

rP699ba2d4abed: (stable) Just fatal for any setting of open_basedir
rP105be01d5f74: Just fatal for any setting of open_basedir

Summary

Fixes T11627.

Beyond being complex, I have no real reason to believe these checks even work (and they don't test repositories, file storage, logfiles, etc).

Test Plan

Faked the error:

Screen Shot 2016-09-12 at 2.42.47 PM.png (1×1 px, 144 KB)

Diff Detail

Repository

rP Phabricator

Branch

setup1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13694
Build 17668: Run Core Tests
Build 17667: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39814.Sep 12 2016, 9:45 PM

epriestley retitled this revision from to Just fatal for any setting of open_basedir.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11627: PhabricatorPHPPreflightSetupCheck can raise a nonfatal `open_basedir` exception which presents the user with a nonfunctional "ignore" action.

chad accepted this revision.Sep 12 2016, 9:47 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 12 2016, 9:47 PM

Closed by commit rP105be01d5f74: Just fatal for any setting of open_basedir (authored by epriestley, committed by epriestley). · Explain WhySep 12 2016, 9:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorPHPPreflightSetupCheck.php

96 lines

Diff 39814

View Options

src/applications/config/check/PhabricatorPHPPreflightSetupCheck.php

Just fatal for any setting of open_basedirClosedPublicActions