Page MenuHomePhabricator
Differential D16543

Move search, new room into thread column in Conpherence
ClosedPublic
Actions

Authored by chad on Sep 12 2016, 6:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 3:52 PM
Unknown Object (File)
Sat, Apr 13, 9:58 AM
Unknown Object (File)
Sun, Apr 7, 1:53 PM
Unknown Object (File)
Sat, Apr 6, 11:13 PM
Unknown Object (File)
Fri, Apr 5, 4:20 PM
Unknown Object (File)
Wed, Apr 3, 4:19 AM
Unknown Object (File)
Tue, Mar 26, 6:52 PM
Unknown Object (File)
Tue, Mar 26, 6:29 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8972: Editing a room edits the previously selected one
Commits
rPd25a9530a7cd: Move search, new room into thread column in Conpherence
Summary

Moves search and new room out of crumb bar and into the thread column. This opens up space to add "Edit Room" into the crumbs area as an action link. Also removed 'widget-edit' pathways and javascript.

Fixes T8972

Test Plan

Search, New, Edit rooms. Click different rooms, see correct URL each time.

pasted_file (751×1 px, 205 KB)

Diff Detail

Repository
rP Phabricator
Branch
new-room (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13692
Build 17664: Run Core Tests
Build 17663: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39812.Sep 12 2016, 6:45 PM
chad retitled this revision from to Move search, new room into thread column in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptSep 12 2016, 6:45 PM
chad edited the test plan for this revision. (Show Details)Sep 12 2016, 6:47 PM
chad updated this revision to Diff 39813.Sep 12 2016, 7:54 PM
  • Check permissions to edit, remove 'widget-edit' pathways
chad updated this object.Sep 12 2016, 7:58 PM
chad added a task: T8972: Editing a room edits the previously selected one.
epriestley accepted this revision.Sep 12 2016, 10:17 PM
epriestley edited edge metadata.

sorta weird maybe but definitely better than what we've got now

This revision is now accepted and ready to land.Sep 12 2016, 10:17 PM
chad added a comment.Sep 12 2016, 10:18 PM

I plan to design out a new header instead of crumbs so we have space for thread search, room topic, etc, so it'll make more sense in a few days.

Closed by commit rPd25a9530a7cd: Move search, new room into thread column in Conpherence (authored by chad, committed by chad). · Explain WhySep 12 2016, 10:19 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Sep 12 2016, 10:29 PM

I see this bug still is alive and well.

pasted_file (194×249 px, 14 KB)

epriestley added a comment.Sep 12 2016, 10:31 PM

I like that bug :3

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
conpherence/
controller/
31 lines
view/
54 lines
webroot/
rsrc/
css/
application/
conpherence/
20 lines

Diff 39812

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/conpherence/controller/ConpherenceController.php

Loading...
View Options

src/applications/conpherence/view/ConpherenceThreadListView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
Phabricator · Built by Phacility