Page MenuHomePhabricator

Move search, new room into thread column in Conpherence
ClosedPublic

Authored by chad on Sep 12 2016, 6:45 PM.

Details

Summary

Moves search and new room out of crumb bar and into the thread column. This opens up space to add "Edit Room" into the crumbs area as an action link. Also removed 'widget-edit' pathways and javascript.

Fixes T8972

Test Plan

Search, New, Edit rooms. Click different rooms, see correct URL each time.

pasted_file (751×1 px, 205 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Move search, new room into thread column in Conpherence.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
  • Check permissions to edit, remove 'widget-edit' pathways
epriestley edited edge metadata.

sorta weird maybe but definitely better than what we've got now

This revision is now accepted and ready to land.Sep 12 2016, 10:17 PM

I plan to design out a new header instead of crumbs so we have space for thread search, room topic, etc, so it'll make more sense in a few days.

This revision was automatically updated to reflect the committed changes.

I see this bug still is alive and well.

pasted_file (194×249 px, 14 KB)