Differential D16525

Check for empty output from git ls-tree
ClosedPublic
Actions

Authored by 20after4 on Sep 9 2016, 2:10 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10155: Error when displaying a repository with only one empty commit

Commits

rPc0bf08058b77: Check for empty output from git ls-tree

Summary

Fixes T10155

Test Plan

View an empty repository in diffusion, check for the exception.
See T10155 for steps to reproduce

Diff Detail

Branch

wmf/stable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13651
Build 17597: arc lint + arc unit

Event Timeline

20after4 updated this revision to Diff 39768.Sep 9 2016, 2:10 AM

20after4 retitled this revision from to Check for empty output from git ls-tree.

20after4 updated this object.

20after4 edited the test plan for this revision. (Show Details)

20after4 added a reviewer: epriestley.

20after4 added a task: T10155: Error when displaying a repository with only one empty commit.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 9 2016, 2:10 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Sep 9 2016, 2:18 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2016, 2:18 AM

chad awarded a token.Sep 9 2016, 2:18 AM

Somehow this didn't autoclose.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

6 lines

Diff 39768

View Options

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

Check for empty output from git ls-treeClosedPublicActions