Page MenuHomePhabricator

Fix a Herald issue where testing commits against rules with revision-related conditions would fail
ClosedPublic

Authored by epriestley on Sep 8 2016, 11:21 PM.
Tags
None
Referenced Files
F15515860: D16522.id39761.diff
Fri, Apr 18, 1:50 PM
F15512825: D16522.id.diff
Thu, Apr 17, 2:09 PM
F15509567: D16522.diff
Wed, Apr 16, 2:08 PM
F15505457: D16522.diff
Tue, Apr 15, 3:08 AM
F15484548: D16522.id39764.diff
Wed, Apr 9, 6:55 PM
F15418218: D16522.id.diff
Mar 20 2025, 9:40 PM
F15378706: D16522.diff
Mar 13 2025, 4:27 PM
Unknown Object (File)
Feb 9 2025, 2:21 AM
Subscribers
None

Details

Summary

Fixes T11610. Clean up some sketchy old code from long ago.

If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal.

Instead, load CommitData in newTestAdapter() and generally make these pathways a little more modern.

Test Plan
  • Wrote an "Accepted Revision Exists" rule.
  • Ran a commit in the test console.
  • Before patch, got fatal from T11610.
  • After patch, got clean test result.
  • Also pushed a commit and reviewed the transcript to make sure the rule ran properly.

Diff Detail

Repository
rP Phabricator
Branch
herald1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13644
Build 17588: Run Core Tests
Build 17587: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix a Herald issue where testing commits against rules with revision-related conditions would fail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 12:08 AM
This revision was automatically updated to reflect the committed changes.