Page MenuHomePhabricator

Fix a Herald issue where testing commits against rules with revision-related conditions would fail
ClosedPublic

Authored by epriestley on Sep 8 2016, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:19 AM
Unknown Object (File)
Sun, Apr 21, 7:20 PM
Unknown Object (File)
Sat, Apr 13, 4:32 AM
Unknown Object (File)
Tue, Apr 9, 4:55 AM
Unknown Object (File)
Feb 18 2024, 4:39 PM
Unknown Object (File)
Feb 12 2024, 5:59 AM
Unknown Object (File)
Feb 5 2024, 11:11 PM
Unknown Object (File)
Feb 1 2024, 9:06 PM
Subscribers
None

Details

Summary

Fixes T11610. Clean up some sketchy old code from long ago.

If you had rules that use conditions like "Accepted revision exists" and ran them in the test console, we'd never load the "CommitData" and fatal.

Instead, load CommitData in newTestAdapter() and generally make these pathways a little more modern.

Test Plan
  • Wrote an "Accepted Revision Exists" rule.
  • Ran a commit in the test console.
  • Before patch, got fatal from T11610.
  • After patch, got clean test result.
  • Also pushed a commit and reviewed the transcript to make sure the rule ran properly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a Herald issue where testing commits against rules with revision-related conditions would fail.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, joshuaspence.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 9 2016, 12:08 AM
This revision was automatically updated to reflect the committed changes.