Page MenuHomePhabricator

Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods
ClosedPublic

Authored by epriestley on Sep 7 2016, 2:38 PM.
Tags
None
Referenced Files
F13889260: D16508.diff
Fri, Oct 4, 9:24 AM
Unknown Object (File)
Mon, Sep 30, 7:45 PM
Unknown Object (File)
Sat, Sep 21, 2:38 AM
Unknown Object (File)
Fri, Sep 13, 12:24 AM
Unknown Object (File)
Wed, Sep 11, 10:03 PM
Unknown Object (File)
Tue, Sep 10, 2:19 AM
Unknown Object (File)
Sep 4 2024, 5:00 AM
Unknown Object (File)
Aug 19 2024, 8:20 AM
Subscribers
None

Details

Summary

Fixes T11593. We ask for a list of values when searching for custom "link" fields, but don't handle it correctly when actually construcitng a query.

Test Plan

Added this custom field:

{
  "mycompany.target-version": {
    "name": "Target Version",
    "type": "link",
    "search": true
  }
}

Set a task to "beta". Let daemons index it. Queried for:

constraints: {
  "custom.mycompany.target-version": [
    "beta"
  ]
}

Got just one result back.

Diff Detail

Repository
rP Phabricator
Branch
iconstraint2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13606
Build 17530: Run Core Tests
Build 17529: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix ContainsConstraints for array-valued custom field constraints in "*.search" methods.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 7 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.