HomePhabricator

Ignore repository versions on inactive devices in "Repository Servers" panel in…

Tags
None
Referenced Files
F1802293: good_sync.png
Sep 5 2016, 6:10 PM
F1802292: bad_partial.png
Sep 5 2016, 6:10 PM
Subscribers
None

Description

Ignore repository versions on inactive devices in "Repository Servers" panel in Config

Summary:
Fixes T11590. Currently, we incorrectly consider cluster repository versions that are (or were) on devices which are no longer part of the active cluster service when building this status screen.

Instead, ignore them. This is just a display bug; the actual ClusterEngine already had similar logic.

Test Plan:

  • Added a bad leader record to repository_workingcopyversion.
  • Before patch, got a bad "Partial (1w)" sync:

bad_partial.png (1×1 px, 177 KB)

  • After patch, got a good "Sycnchronized":

good_sync.png (1×1 px, 178 KB)

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11590

Differential Revision: https://secure.phabricator.com/D16492