Page MenuHomePhabricator

Update documentation for text linter

Authored by nfirmani on Aug 26 2016, 8:05 PM.



Resolves T11520

Test Plan

Previewed the file in an editor window to make sure it looks good.

Diff Detail

rP Phabricator
Lint OK
No Unit Test Coverage
Build Status
Buildable 13471
Build 17320: arc lint + arc unit

Event Timeline

nfirmani updated this revision to Diff 39596.Aug 26 2016, 8:05 PM
nfirmani retitled this revision from to Update documentation for text linter.
nfirmani updated this object.
nfirmani edited the test plan for this revision. (Show Details)
nfirmani added a reviewer: epriestley.

Any update on this?

epriestley edited edge metadata.Dec 15 2016, 12:40 PM

I think a better fix here is to accept either "TXT3" or "3" as keys. I'd rather do that than just document the current not-so-good behavior.

Generally, see T10038 for discussion. I think T3914 has some discussion of this issue in particular, although it is quite old.

Offhand, T8474, T9626, T4287 are also somewhat related.

In a vacuum, this patch is fine, but in the long term it's something we'd likely have to undo when we improve linter behavior. I don't plan to tackle any of this until the next major iteration on lint, which will probably occur after T4287/T11429 and alongside T5055 coming online.

nfirmani abandoned this revision.Jan 22 2017, 8:36 PM

The simplest bugs are always the most complicated.. However, judging by the number of tickets about this issue (T3914, the ones referenced in T8474, T11520), perhaps it's worth the cost of reverting this documentation later vs handling more support tickets. I'll leave that up to you though!