Page MenuHomePhabricator

When importing Git repositories, treat out-of-range timestamps as the current time
ClosedPublic

Authored by epriestley on Aug 26 2016, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 5:17 PM
Unknown Object (File)
Thu, Apr 25, 3:47 AM
Unknown Object (File)
Fri, Apr 19, 5:15 PM
Unknown Object (File)
Sun, Apr 14, 10:11 PM
Unknown Object (File)
Sun, Apr 7, 10:08 PM
Unknown Object (File)
Apr 4 2024, 12:48 PM
Unknown Object (File)
Apr 2 2024, 1:44 AM
Unknown Object (File)
Mar 30 2024, 8:46 AM
Subscribers
None

Details

Summary

Fixes T11537. See that task for discussion.

Although we could accommodate these faithfully, it requires a huge migration and affects one repository on one install which was written with buggy tools.

At least for now, just replace out-of-32-bit-range epoch values with the current time, which is often somewhat close to the real value.

Test Plan
  • Following the instructions in T11537, created commits in 40,000 AD.
  • Tried to import them, reproducing the "epoch" database issue.
  • Applied the patch.
  • Successfully imported future-commits, with some liberties around commit dates. Note that author date (not stored in an epoch column) is still shown faithfully:

Screen Shot 2016-08-26 at 5.20.09 AM.png (237×409 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Branch
epoch-clamp
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13458
Build 17300: Run Core Tests
Build 17299: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When importing Git repositories, treat out-of-range timestamps as the current time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Aug 26 2016, 1:35 PM
This revision was automatically updated to reflect the committed changes.