Page MenuHomePhabricator

When importing Git repositories, treat out-of-range timestamps as the current time
ClosedPublic

Authored by epriestley on Aug 26 2016, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 5:04 AM
Unknown Object (File)
Sun, Dec 8, 8:54 PM
Unknown Object (File)
Thu, Dec 5, 12:24 PM
Unknown Object (File)
Mon, Dec 2, 10:57 AM
Unknown Object (File)
Wed, Nov 27, 2:47 AM
Unknown Object (File)
Tue, Nov 26, 12:41 PM
Unknown Object (File)
Fri, Nov 22, 11:16 PM
Unknown Object (File)
Nov 19 2024, 4:32 AM
Subscribers
None

Details

Summary

Fixes T11537. See that task for discussion.

Although we could accommodate these faithfully, it requires a huge migration and affects one repository on one install which was written with buggy tools.

At least for now, just replace out-of-32-bit-range epoch values with the current time, which is often somewhat close to the real value.

Test Plan
  • Following the instructions in T11537, created commits in 40,000 AD.
  • Tried to import them, reproducing the "epoch" database issue.
  • Applied the patch.
  • Successfully imported future-commits, with some liberties around commit dates. Note that author date (not stored in an epoch column) is still shown faithfully:

Screen Shot 2016-08-26 at 5.20.09 AM.png (237×409 px, 24 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When importing Git repositories, treat out-of-range timestamps as the current time.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Aug 26 2016, 1:35 PM
This revision was automatically updated to reflect the committed changes.