Fixes T9692. Instead of disallowing API tokens entirely, we're going to just warn the user that they might not want to do that. After that, they can proceed if they want to.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T9692: Warn but continue when installing bot certificates with `arc install-certificate`
- Commits
- rARC10e519475290: (stable) Promote 2016 Week 35
rARC9e82ef979e81: Added a warning prompt if the user tries to use an API cert instead of a CLI…
Run arc install-certificate.
Manually go to Settings → Conduit API Tokens in the web UI.
Generate an API token explicitly, which should have the form api-**.
Paste that into the prompt on the CLI.
It will give you a warning prompt then ask if you'd like to proceed anyway (defaults to No).
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- AllowStdAPICerts (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 13439 Build 17268: Run Core Tests Build 17267: arc lint + arc unit
Event Timeline
Comment Actions
One inline about translations. This is moot today since there's no way to set arc to a different language, but will likely become relevant soon (T5267).
| src/workflow/ArcanistInstallCertificateWorkflow.php | ||
|---|---|---|
| 127 | Use pht() here, to make these messages ("Install this..."), ("Not installing...") translatable. See here for more details about error/exception translations, or the rest of this document for discussion of pht(): https://secure.phabricator.com/book/phabcontrib/article/internationalization/#exceptions-and-errors | |