Page MenuHomePhabricator

Migrate the "badcommit" table to use the less-hacky "hint" mechanism
ClosedPublic

Authored by epriestley on Aug 24 2016, 12:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 4:52 PM
Unknown Object (File)
Mon, Dec 9, 5:02 PM
Unknown Object (File)
Sat, Dec 7, 4:08 AM
Unknown Object (File)
Thu, Dec 5, 2:20 AM
Unknown Object (File)
Tue, Dec 3, 1:24 PM
Unknown Object (File)
Nov 19 2024, 9:24 PM
Unknown Object (File)
Nov 16 2024, 10:23 AM
Unknown Object (File)
Nov 12 2024, 5:33 AM
Subscribers
None

Details

Summary

Ref T11522. This migrates any "badcommit" data (which probably only exists at Facebook and on 1-2 other installs in the wild) to the new "hint" table.

Test Plan
  • Wrote some bad commit annotations to the badcommit table.
  • Viewed them in the web UI and used bin/repository reparse --change ... to reparse them. Saw "this is bad" messages.
  • Ran migration, verified that valid "badcommit" rows were successfully migrated to become "hint" rows.
  • Viewed the new web UI and re-parsed the change, saw "unreadable commit" messages.
  • Viewed a good commit; reparsed a good commit.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Migrate the "badcommit" table to use the less-hacky "hint" mechanism.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 3:56 PM
This revision was automatically updated to reflect the committed changes.