Page MenuHomePhabricator
Differential D16430

Explain how cats use their time
ClosedPublic
Actions

Authored by jcox on Aug 22 2016, 7:18 PM.
Tags
None
Referenced Files
F14725306: D16430.diff
Sat, Jan 18, 2:12 AM
Unknown Object (File)
Tue, Jan 14, 8:54 PM
Unknown Object (File)
Tue, Jan 7, 4:32 AM
Unknown Object (File)
Tue, Dec 31, 7:22 PM
Unknown Object (File)
Tue, Dec 24, 1:47 AM
Unknown Object (File)
Dec 12 2024, 2:04 PM
Unknown Object (File)
Dec 7 2024, 1:21 AM
Unknown Object (File)
Dec 1 2024, 5:44 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPb521f2349e46: Explain how cats use their time
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Added a brand new shiny cat fact

Test Plan

Pulled up a project with motivator installed and nothing broke

Diff Detail

Repository
rP Phabricator
Branch
newcatfact (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13389
Build 17186: Run Core Tests
Build 17185: arc lint + arc unit

Event Timeline

jcox updated this revision to Diff 39513.Aug 22 2016, 7:18 PM
jcox retitled this revision from to Explain how cats use their time.
jcox updated this object.
jcox edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 22 2016, 7:18 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley accepted this revision.Aug 22 2016, 7:25 PM
epriestley added a reviewer: epriestley.

Thanks for discovering this great cat fact! You have contributed to humanity's understanding of cats.

I added you to Blessed Committers, so you should be able to land this yourself using arc land or the "Land Revision" action here in the web UI. See the description for that project for details and possible help if things don't seem to be working

I've also added you to Community, granting you sweeping new janitorial powers on this install.

src/applications/search/profilepanel/PhabricatorMotivatorProfilePanel.php
146

For consistency with the other strings, add a period at the end of the sentence ("owner" -> "owner.")

This revision is now accepted and ready to land.Aug 22 2016, 7:25 PM
jcox updated this revision to Diff 39514.Aug 22 2016, 7:38 PM
jcox edited edge metadata.
  • Added a period for consistency
Herald added a subscriber: Korvin. · View Herald TranscriptAug 22 2016, 7:38 PM
Closed by commit rPb521f2349e46: Explain how cats use their time (authored by jcox, committed by jcox). · Explain WhyAug 22 2016, 7:45 PM
This revision was automatically updated to reflect the committed changes.
jcox marked an inline comment as done.

Revision Contents
Changeset List

PathSize
src/
applications/
search/
profilepanel/
3 lines

Diff 39513

View Options

src/applications/search/profilepanel/PhabricatorMotivatorProfilePanel.php

Loading...
Phabricator · Built by Phacility