Paths

Table of Contentst

Differential D16423

Add a missing table key to improve performance of "Recently Completed Tasks" query
ClosedPublic
Actions

Authored by epriestley on Aug 19 2016, 6:32 PM.

Details

Reviewers

chad

Maniphest Tasks

T11490: phabricator_worker.worker_archivetask has unkeyed query on dateModified

Commits

rP3bd0da0ec243: Add a missing table key to improve performance of "Recently Completed Tasks"…

Summary

Fixes T11490. Currently, this query can not use a key and the table size may be quite large.

Adjust the query so it can use a key for both selection and ordering, and add that key.

Test Plan

Ran EXPLAIN on the old query in production, then added the key and ran EXPLAIN on the new query. Saw key in use, and "rows" examined drop from 29,273 to 15.

Diff Detail

Repository

rP Phabricator

Branch

dkey

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13368
Build 17155: Run Core Tests
Build 17154: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39493.Aug 19 2016, 6:32 PM

epriestley retitled this revision from to Add a missing table key to improve performance of "Recently Completed Tasks" query.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11490: phabricator_worker.worker_archivetask has unkeyed query on dateModified.

chad accepted this revision.Aug 19 2016, 6:41 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2016, 6:41 PM

Closed by commit rP3bd0da0ec243: Add a missing table key to improve performance of "Recently Completed Tasks"… (authored by epriestley, committed by epriestley). · Explain WhyAug 19 2016, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

query/

PhabricatorWorkerArchiveTaskQuery.php

2 lines

storage/

PhabricatorWorkerArchiveTask.php

3 lines

Diff 39493

View Options

src/infrastructure/daemon/workers/query/PhabricatorWorkerArchiveTaskQuery.php