Page MenuHomePhabricator

Simplify how tag lists manage their handles
ClosedPublic

Authored by epriestley on Aug 19 2016, 5:45 PM.
Tags
None
Referenced Files
F14056180: D16422.diff
Sat, Nov 16, 6:41 PM
F14012849: D16422.id.diff
Fri, Nov 1, 8:16 PM
F14000510: D16422.diff
Thu, Oct 24, 10:24 PM
F13982414: D16422.id39492.diff
Oct 19 2024, 11:05 PM
F13971822: D16422.id.diff
Oct 17 2024, 3:32 PM
Unknown Object (File)
Oct 4 2024, 6:29 AM
Unknown Object (File)
Sep 1 2024, 10:24 AM
Unknown Object (File)
Aug 29 2024, 5:08 PM
Subscribers
None

Details

Summary

Fixes T11493. This code is a little bit weird/clever, simplify it so that we always cast the handles to an array early on.

Test Plan

Screen Shot 2016-08-19 at 10.42.44 AM.png (377×785 px, 55 KB)

Diff Detail

Repository
rP Phabricator
Branch
hlist1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13366
Build 17152: Run Core Tests
Build 17151: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Simplify how tag lists manage their handles.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Should we make this "show all tags" instead? In case they want to be clicked on?

I think retaining the tooltip is probably good regardless. We could additionally let you click the (...) tag to pop up a dialog of the other tags, I guess, but since no one has ever asked for that it doesn't seem too valuable to me offhand.

chad edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2016, 6:05 PM

Well, I don't know how useful the tooltip really is, actually. It seems sort of nice but it's possible that no one ever uses it.

I'd guess the individual tags on stuff with 5+ tags probably isn't all that useful most of the time, maybe? Not really sure.

This revision was automatically updated to reflect the committed changes.