Page MenuHomePhabricator

Support the Midje testing framework for Clojure
Needs ReviewPublic

Authored by urzds on Aug 16 2016, 1:04 AM.

Details

Reviewers
None
Group Reviewers
Blessed Reviewers
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Still has a few rough edges, but not worse than the other non-phutil test engines.

Midje is a testing framework for Clojure with integration into the Leiningen build tool:

Test Plan
  • Affected-Files mode
    1. Modified one file in a Git working copy
    2. Ran arc unit --trace
    3. Saw it properly running lein midje
    4. Confirmed the JUnit XML files were created and that the test results were correct
    5. Repeated the same with two modified files at the same time
  • Everything mode
    1. Ran arc unit --trace --everything
    2. Saw it properly running lein midje
    3. Confirmed the JUnit XML files were created and that the test results were correct

Diff Detail

Repository
rARC Arcanist
Branch
feature/arcanist-unit-midje (branched from stable)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 13321
Build 17083: arc lint + arc unit

Event Timeline

urzds updated this revision to Diff 39441.Aug 16 2016, 1:04 AM
urzds retitled this revision from to Support the Midje testing framework for Clojure.
urzds updated this object.
urzds edited the test plan for this revision. (Show Details)
urzds added a reviewer: Blessed Reviewers.
urzds updated this revision to Diff 39443.Aug 16 2016, 11:15 AM
urzds edited edge metadata.

Refactored stripPathPrefix(), pathToNamespace(), etc. to be more generic

avivey added a subscriber: avivey.Aug 16 2016, 10:47 PM

Firstly:

Content Hidden
The content of this revision is hidden until the author has signed all of the required legal agreements.

Secondly, no lint or unit binder is likely to get any upstream attention until after T10038 or T5055.

urzds added a comment.Aug 17 2016, 8:45 AM

Firstly:

Content Hidden
The content of this revision is hidden until the author has signed all of the required legal agreements.

I am working with my employer on that.

Secondly, no lint or unit binder is likely to get any upstream attention until after T10038 or T5055.

I added arcanist-extensions-midje to Community Resources for now.

urzds added a comment.Aug 17 2016, 3:22 PM

I just had an official "sign" the L30 agreement for our institution:

  1. I filled in the details, naming them as the organisation's contact
  2. I pressed the "sign" button
  3. They clicked the link, that was sent to them by email

How to proceed from there?

For now, we have to manually add CLA exemptions for users who are part of organizations. I've added you, so the CLA issue should be all set.