Page MenuHomePhabricator

Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine
ClosedPublic

Authored by epriestley on Aug 14 2016, 1:46 PM.
Tags
None
Referenced Files
F14063332: D16395.diff
Mon, Nov 18, 5:50 PM
F14054567: D16395.id.diff
Sat, Nov 16, 2:54 AM
F14047842: D16395.diff
Thu, Nov 14, 5:31 AM
F13963435: D16395.diff
Oct 15 2024, 3:55 PM
Unknown Object (File)
Oct 7 2024, 2:55 AM
Unknown Object (File)
Aug 25 2024, 5:18 AM
Unknown Object (File)
Aug 25 2024, 2:12 AM
Unknown Object (File)
Aug 23 2024, 10:06 PM
Subscribers
Restricted Owners Package
Tokens
"Y So Serious" token, awarded by michaeljs1990.

Details

Summary

Ref T11473. When running harbormaster.build.search with a buildables constraint, the constraint doesn't get passed to the Query and so currently has no effect.

This piece of logic was just accidentally omitted from D16356. It is probably not used anywhere today and doesn't show up in the UI, so it's easy to overlook (I missed it in review, too).

Test Plan

Ran harbormaster.build.search with a buildables constraint, got expected filtering.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Execute Harbormaster buildable filtering properly from HarbormasterBuildSearchEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
Owners added a subscriber: Restricted Owners Package.Aug 14 2016, 1:46 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 14 2016, 3:05 PM
This revision was automatically updated to reflect the committed changes.