Details
Viewed a transcript, clicked rule names, reviewed rules.
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
src/applications/herald/controller/HeraldTranscriptController.php | ||
---|---|---|
252 | Is there a need to pht this? |
It probably shouldn't be pht()'d.
We used to do more pht('D%d: %s', $id, $title) stuff, particularly in Handle queries IIRC, which probably wasn't right either, but is at least sort of theoretically valid if : isn't a great separator character in some language.
Now that objects usually have a getMonogram(), this looks more like pht('%s: %s', $monogram, $title). Still probably a little silly, but maybe that's more conventional as - or ~ or something in Chinese. But I don't think there's any reason for the monogram construction itself to be translatable.
I figure we'll just clean this stuff up more generally in the future -- this code still really isn't "right", and it should probably load the rule and just call getMonogram() on it mooting the whole issue. At some point Herald needs a cleanup pass for transaction rendering and I imagine just cleaning up all this little stuff then.