Page MenuHomePhabricator

Let everyone view Herald rules
ClosedPublic

Authored by epriestley on Aug 10 2016, 1:20 AM.
Tags
None
Referenced Files
F13091587: D16382.diff
Thu, Apr 25, 3:05 AM
Unknown Object (File)
Fri, Apr 19, 5:12 PM
Unknown Object (File)
Thu, Apr 18, 10:20 PM
Unknown Object (File)
Wed, Apr 3, 5:05 PM
Unknown Object (File)
Sun, Mar 31, 7:50 AM
Unknown Object (File)
Sat, Mar 30, 5:33 PM
Unknown Object (File)
Fri, Mar 29, 4:51 AM
Unknown Object (File)
Mar 24 2024, 8:56 PM
Subscribers
None

Details

Summary

Ref T9410. This changes the view policy for all Herald rules to the most public policy ("All Users" for private installs, "Public" for public installs).

See T11428 for discussion of this change in greater detail. In practice, this is approximately how things work today anyway, since you can almost always see almost all of this information in transcripts.

I believe this narrower view policy is helpful in zero cases and slightly confusing or harmful in a number of reasonable cases.

Test Plan

Viewed personal, object and global rules as users who could and could not edit the rules.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Let everyone view Herald rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 1:46 AM
This revision was automatically updated to reflect the committed changes.