Page MenuHomePhabricator
Differential D16379

Remove PHUIDocumentView
ClosedPublic
Actions

Authored by chad on Aug 8 2016, 1:16 AM.
Tags
None
Referenced Files
F14063396: D16379.diff
Mon, Nov 18, 6:24 PM
F14045270: D16379.diff
Wed, Nov 13, 2:32 AM
F14017045: D16379.id39392.diff
Mon, Nov 4, 1:55 PM
F14013702: D16379.id39393.diff
Sat, Nov 2, 10:36 AM
F14013701: D16379.id39392.diff
Sat, Nov 2, 10:36 AM
F14001575: D16379.id39393.diff
Fri, Oct 25, 9:43 AM
F13995620: D16379.id39394.diff
Wed, Oct 23, 2:17 PM
F13993331: D16379.id.diff
Tue, Oct 22, 10:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
rP679fbada448e: Remove PHUIDocumentView
Summary

Converts final call site to PHUIDocumentViewPro.

Test Plan

grep for PHUIDocumentView, view new Welcome Page

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13269
Build 17009: Run Core Tests
Build 17008: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39392.Aug 8 2016, 1:16 AM
chad retitled this revision from to Remove PHUIDocumentView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptAug 8 2016, 1:16 AM
chad updated this revision to Diff 39393.Aug 8 2016, 3:05 AM
  • remove unused CSS, need to combine
epriestley accepted this revision.Aug 8 2016, 4:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 8 2016, 4:06 PM
Closed by commit rP679fbada448e: Remove PHUIDocumentView (authored by chad, committed by chad). · Explain WhyAug 8 2016, 4:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
4 lines
applications/
config/
controller/
7 lines
uiexample/
examples/
view/
phui/
webroot/
rsrc/
css/
application/
config/
7 lines

Diff 39392

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...
View Options

src/applications/uiexample/examples/PHUIDocumentExample.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

webroot/rsrc/css/application/config/config-welcome.css

Loading...
Phabricator · Built by Phacility