Page MenuHomePhabricator

Add support for Differential Diffs to phid.lookup / PhabricatorObjectQuery
Needs ReviewPublic

Authored by dpkp on Aug 7 2016, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 17, 10:42 AM
Unknown Object (File)
Fri, Aug 12, 8:37 AM
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Fri, Aug 12, 12:06 AM
Unknown Object (File)
Sat, Jul 30, 2:14 AM
Unknown Object (File)
Tue, Jul 26, 4:32 AM
Unknown Object (File)
Jul 17 2022, 10:31 PM
Subscribers

Details

Summary

Fix T11439

Test Plan

Tested phid.lookup(names=["Diff 15"])

Diff Detail

Repository
rP Phabricator
Branch
phid_lookup_diff
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 13262
Build 16999: arc lint + arc unit

Event Timeline

dpkp retitled this revision from to Add support for Differential Diffs to phid.lookup / PhabricatorObjectQuery.
dpkp updated this object.
dpkp edited the test plan for this revision. (Show Details)
dpkp added reviewers: epriestley, joshuaspence.

This is always super confusing because "Revisions" start with a "D" in their monogram, but a "diff" literally begins with the letter D while a revision does not.

I agree it's probably useful for this to exist but maybe we should come up with a better way of referring to a "diff" as opposed to a revision?