Differential D16376

Add support for Differential Diffs to phid.lookup / PhabricatorObjectQuery
Needs ReviewPublic
Actions

Authored by dpkp on Aug 7 2016, 5:59 PM.

Tags

None

Referenced Files

	F18460048: D16376.id.diff
	Mon, Sep 1, 6:34 PM

	F18440683: D16376.diff
	Sun, Aug 31, 3:55 PM

	F18435701: D16376.diff
	Sun, Aug 31, 10:19 AM

	F18094124: D16376.diff
	Thu, Aug 7, 9:58 PM

	F17981695: D16376.id.diff
	Aug 1 2025, 7:10 PM

	F17944565: D16376.diff
	Jul 31 2025, 10:31 AM

	Unknown Object (File)
	Jun 18 2025, 9:57 AM

	Unknown Object (File)
	Jun 17 2025, 5:11 AM

Subscribers

Details

Reviewers

joshuaspence
epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T11439: Retrieve Diff PHID via phid.lookup

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Test Plan

Tested phid.lookup(names=["Diff 15"])

Diff Detail

Repository

Branch

phid_lookup_diff

Lint

Lint Passed

Unit

Tests Skipped

Build Status

Buildable 13262
Build 16999: arc lint + arc unit

Event Timeline

dpkp updated this revision to Diff 39385.Aug 7 2016, 5:59 PM

dpkp retitled this revision from to Add support for Differential Diffs to phid.lookup / PhabricatorObjectQuery.

dpkp updated this object.

dpkp edited the test plan for this revision. (Show Details)

dpkp added reviewers: epriestley, joshuaspence.

dpkp added a task: T11439: Retrieve Diff PHID via phid.lookup.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 7 2016, 5:59 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: Korvin. · View Herald Transcript

This is always super confusing because "Revisions" start with a "D" in their monogram, but a "diff" literally begins with the letter D while a revision does not.

I agree it's probably useful for this to exist but maybe we should come up with a better way of referring to a "diff" as opposed to a revision?

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

phid/

DifferentialDiffPHIDType.php

29 lines

Diff 39385

src/applications/differential/phid/DifferentialDiffPHIDType.php

Loading...