Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`

Authored by epriestley on Aug 6 2016, 1:41 PM.
Referenced Files
F13343487: D16375.id39379.diff
Fri, Jun 21, 2:14 AM
F13342556: D16375.diff
Thu, Jun 20, 3:21 PM
F13324817: D16375.diff
Sat, Jun 15, 1:01 AM
F13312216: D16375.diff
Tue, Jun 11, 6:16 AM
F13308894: D16375.id39379.diff
Mon, Jun 10, 7:31 AM
F13303819: D16375.id39379.diff
Sat, Jun 8, 7:19 AM
F13298149: D16375.diff
Fri, Jun 7, 6:22 AM
F13295592: D16375.id39379.diff
Thu, Jun 6, 5:25 AM



Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.