Page MenuHomePhabricator

Use --no-ext-diff in `arc land` call to `git diff`
ClosedPublic

Authored by epriestley on Aug 6 2016, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 8:59 PM
Unknown Object (File)
Fri, Jan 24, 3:16 PM
Unknown Object (File)
Fri, Jan 24, 3:16 PM
Unknown Object (File)
Fri, Jan 24, 3:15 PM
Unknown Object (File)
Fri, Jan 24, 3:15 PM
Unknown Object (File)
Tue, Jan 21, 11:02 AM
Unknown Object (File)
Sat, Jan 18, 1:05 AM
Unknown Object (File)
Thu, Jan 9, 12:47 AM
Subscribers
None

Details

Summary

Fixes T11435. This isn't a perfect solution since there's a little code duplication, but a perfect solution is probably a bit more involved.

See T11435 for some discussion. In particular, most git diff commands already get this flag via ArcanistGitAPI->getDiffBaseOptions().

Test Plan

Will land this change.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use --no-ext-diff in `arc land` call to `git diff`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 6 2016, 2:18 PM
This revision was automatically updated to reflect the committed changes.