Page MenuHomePhabricator

let arc patch authenticate in more cases
Needs ReviewPublic

Authored by eadler on Aug 5 2016, 9:56 AM.

Details

Reviewers
magnetik
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error.
Commits
Restricted Diffusion Commit
Summary

fixes T11434

Test Plan

ran ./bin/arc patch against secure. with an empty arcrc
also tried running locally (though its harder since I need to fake a
patch)

Diff Detail

Repository
rARC Arcanist
Branch
eax/T11434 (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 13251
Build 16985: Run Core Tests
Build 16984: arc lint + arc unit

Event Timeline

eadler updated this revision to Diff 39373.Aug 5 2016, 9:56 AM
eadler retitled this revision from to fix arc patch.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: magnetik.
magnetik accepted this revision.Aug 5 2016, 10:02 AM
magnetik edited edge metadata.

Good for me

avivey retitled this revision from fix arc patch to let arc patch authenticate in more cases.Aug 5 2016, 6:51 PM
avivey edited edge metadata.
avivey added a subscriber: avivey.Aug 5 2016, 6:55 PM

LGTM... We don't actually list all the possible errors anywhere, do we?

Is there anything I can do to make this move forward?

Is there anything I can do to make this move forward?

No.

Rtls added a commit: Restricted Diffusion Commit.Nov 24 2016, 6:18 AM