Page MenuHomePhabricator
Differential D16372

let arc patch authenticate in more cases
Needs ReviewPublic
Actions

Authored by eadler on Aug 5 2016, 9:56 AM.
Tags
None
Referenced Files
F15574881: D16372.diff
Tue, May 6, 3:47 AM
F15555139: D16372.id39373.diff
Mon, Apr 28, 10:02 AM
F15517769: D16372.diff
Sat, Apr 19, 8:17 AM
F15503554: D16372.id39373.diff
Mon, Apr 14, 10:43 AM
F15503176: D16372.id.diff
Mon, Apr 14, 7:37 AM
F15496573: D16372.diff
Sun, Apr 13, 7:14 AM
F15464608: D16372.id.diff
Apr 2 2025, 11:12 AM
Unknown Object (File)
Feb 21 2025, 5:10 PM
View All Files
Subscribers
avivey
epriestley
gou1

Details

Reviewers
magnetik
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error.
Commits
Restricted Diffusion Commit
Summary

fixes T11434

Test Plan

ran ./bin/arc patch against secure. with an empty arcrc
also tried running locally (though its harder since I need to fake a
patch)

Diff Detail

Repository
rARC Arcanist
Branch
eax/T11434 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13251
Build 16985: Run Core Tests
Build 16984: arc lint + arc unit

Event Timeline

eadler updated this revision to Diff 39373.Aug 5 2016, 9:56 AM
eadler retitled this revision from to fix arc patch.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: magnetik.
eadler added a task: T11434: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error..
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 5 2016, 9:56 AM
Herald added a subscriber: epriestley. · View Herald Transcript
magnetik accepted this revision.Aug 5 2016, 10:02 AM
magnetik edited edge metadata.

Good for me

avivey retitled this revision from fix arc patch to let arc patch authenticate in more cases.Aug 5 2016, 6:51 PM
avivey edited edge metadata.
avivey added a subscriber: avivey.Aug 5 2016, 6:55 PM

LGTM... We don't actually list all the possible errors anywhere, do we?

magnetik added a comment.Aug 29 2016, 7:01 AM

Is there anything I can do to make this move forward?

epriestley added a comment.Aug 29 2016, 6:08 PM
In D16372#193250, @magnetik wrote:

Is there anything I can do to make this move forward?

No.

gou1 mentioned this in Q398: Arc patch fails: EXCEPTION: (ConduitClientException) ERR-INVALID-AUTH: Unknown Error (Answer 395).Nov 4 2016, 11:34 AM
gou1 added a subscriber: gou1.
• Rtls added a commit: Restricted Diffusion Commit.Nov 24 2016, 6:18 AM

Revision Contents
Changeset List

PathSize
src/
workflow/
3 lines

Diff 39373

View Options

src/workflow/ArcanistPatchWorkflow.php

Loading...
Phabricator · Built by Phacility