Page MenuHomePhabricator

Add PackagesPackage
ClosedPublic

Authored by epriestley on Jul 21 2016, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 7:14 PM
Unknown Object (File)
Mon, Mar 25, 4:36 PM
Unknown Object (File)
Mon, Mar 25, 4:32 PM
Unknown Object (File)
Mon, Mar 25, 3:44 PM
Unknown Object (File)
Mon, Mar 25, 3:26 PM
Unknown Object (File)
Mon, Mar 25, 3:17 PM
Unknown Object (File)
Wed, Mar 20, 4:29 PM
Unknown Object (File)
Wed, Mar 20, 3:45 PM
Subscribers

Details

Summary

Ref T8116. A package has:

  • a publisher (like "Phacility"), from the previous revision;
  • a name (like "Arcanist");
  • a package key (like "arcanist").

The package key is immutable, like the publisher key.

This gives a package a full key like "phacility/arcanist".

Policy stuff:

  • You must be able to view a publisher to view a package (currently, everyone can always see all publishers).
  • You must be able to edit a publisher to create a new package inside it.
  • Packages have separate view/edit permissions.

This still does nothing interesting.

Test Plan

Screen Shot 2016-07-21 at 10.53.05 AM.png (970×1 px, 130 KB)

Diff Detail

Repository
rP Phabricator
Branch
pack2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13112
Build 16768: Run Core Tests
Build 16767: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add PackagesPackage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

generic concern: this might be confusing w.r.t. to Owners packages. Maybe we should call these 'Extensions' (though this is confusing w.r.t. the extensions/ directory)?

Here's my incredibly clever plan around that, at least for now: T5055#132849

chad edited edge metadata.
This revision is now accepted and ready to land.Jul 24 2016, 3:30 AM
This revision was automatically updated to reflect the committed changes.