Differential D16313

Raise human-readable error messages for overlong Phame blog titles and subtitles
ClosedPublic
Actions

Authored by epriestley on Jul 21 2016, 2:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T11358: Phame raises exception when 'subtitle' field too long

Commits

rPc27ba19da3b7: Raise human-readable error messages for overlong Phame blog titles and subtitles

Summary

Fixes T11358. Entering a too-long title/subtitle currently raises an unfriendly (database-level) error.

Raise a friendlier error.

Test Plan

Screen Shot 2016-07-21 at 7.13.06 AM.png (1×1 px, 192 KB)

Diff Detail

Repository

rP Phabricator

Branch

phame1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13109
Build 16762: Run Core Tests
Build 16761: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 39232.Jul 21 2016, 2:15 PM

epriestley retitled this revision from to Raise human-readable error messages for overlong Phame blog titles and subtitles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11358: Phame raises exception when 'subtitle' field too long.

epriestley mentioned this in T11358: Phame raises exception when 'subtitle' field too long.Jul 21 2016, 2:19 PM

jonathanrseawright awarded a token.Jul 21 2016, 2:24 PM

chad accepted this revision.Jul 21 2016, 3:13 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 21 2016, 3:13 PM

Closed by commit rPc27ba19da3b7: Raise human-readable error messages for overlong Phame blog titles and subtitles (authored by epriestley, committed by epriestley). · Explain WhyJul 21 2016, 4:48 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

editor/

PhameBlogEditor.php

27 lines

Diff 39232

View Options

src/applications/phame/editor/PhameBlogEditor.php

Raise human-readable error messages for overlong Phame blog titles and subtitlesClosedPublicActions