Page MenuHomePhabricator

Use phutil functions to copy/move files
ClosedPublic

Authored by alexmv on Jul 11 2016, 10:45 PM.

Details

Summary

The cp and mv commands, when run from a Windows
environment, error out. Use library functions from Filesystem
for cross-platform compatibility.

Test Plan

Ran arc lint with auto-fix lint errors on both Linux and
Windows.

Diff Detail

Repository
rARC Arcanist
Branch
upstream-windows-lintpatcher
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 13027
Build 16645: arc lint + arc unit

Event Timeline

alexmv retitled this revision from to Provide windows command-line equivalents for `cp` and `mv` commands.Jul 11 2016, 10:45 PM
alexmv updated this object.
alexmv edited the test plan for this revision. (Show Details)
alexmv updated this revision to Diff 39145.
epriestley requested changes to this revision.

These should go in Filesystem in libphutil, as copyFile($src, $dst) and something like overwriteFile($src, $dst), and have unit tests so they survive the coming apocalypse in T8298 / D15675.

This revision now requires changes to proceed.Jul 11 2016, 11:23 PM
alexmv edited edge metadata.
alexmv updated this revision to Diff 39148.

Use new libphutil functions.

alexmv retitled this revision from Provide windows command-line equivalents for `cp` and `mv` commands to Use phutil functions to copy/move files.Jul 12 2016, 12:20 AM
alexmv updated this object.
alexmv edited edge metadata.
epriestley edited edge metadata.Jul 12 2016, 1:26 PM
epriestley accepted this revision.
This revision is now accepted and ready to land.Jul 12 2016, 1:26 PM

Thanks! Looks like you're already in Blessed Committers. I added you to Community for good measure.

This revision was automatically updated to reflect the committed changes.