Page MenuHomePhabricator

When users choose a default project icon, make a permanent file
ClosedPublic

Authored by epriestley on Jul 11 2016, 3:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 4:31 PM
Unknown Object (File)
Thu, Apr 25, 1:44 AM
Unknown Object (File)
Thu, Apr 18, 2:10 PM
Unknown Object (File)
Tue, Apr 16, 10:24 AM
Unknown Object (File)
Mon, Apr 1, 3:19 AM
Unknown Object (File)
Mon, Apr 1, 3:19 AM
Unknown Object (File)
Mon, Apr 1, 3:19 AM
Unknown Object (File)
Mon, Apr 1, 3:19 AM
Subscribers
None

Details

Summary

Fixes T10907. As written, this workflow will incorrectly reuse a temporary file if one exists.

Instead, make a new permanent file.

(Storage is still shared, so this usually will not actually create a copy of the file's data.)

Test Plan
  • Set a project's icon by clicking first button in "Use Picture" row.
  • Before patch: temporary image was reused.
  • After patch: new permanent file is generated.

Diff Detail

Repository
rP Phabricator
Branch
file1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 13016
Build 16631: Run Core Tests
Build 16630: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to When users choose a default project icon, make a permanent file.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 3:27 PM
This revision was automatically updated to reflect the committed changes.